Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for Tomcat 10 #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nihlus
Copy link

@Nihlus Nihlus commented Mar 24, 2024

This PR implements support for Tomcat 10, updating some method overrides and removing obsoleted functionality. Most of the changes have been made rather naively, and will probably need some tweaking and/or change requests before they can be merged.

The proposed changes compile fine on a Debian 12 machine with the current stable packages; however, these may not match versions in other distributions.

CC @tjaalton. Closes #68.

@tjaalton
Copy link

I wonder if it would be easier to land this to have it next to tomcat-9.0 support? Fedora doesn't even have tomcat10 yet, as you can see from the failing rpm builds.

@Nihlus
Copy link
Author

Nihlus commented Mar 25, 2024

Possibly, though Tomcat 10 support needs modifications to the public API of the common core library, so I'm not entirely sure if it's doable without a major version bump either way. I'd like to hear from the devs on that.

@Nihlus
Copy link
Author

Nihlus commented Mar 26, 2024

I added a way to switch between Tomcat 9 and Tomcat 10 support via two Maven build properties. This necessitated moving Http11NioProtocol to the tomcat-x.0 subprojects, but I think that's an alright tradeoff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tomcat 10 support
2 participants