feat: use changeset instead of lerna #369
Conversation
WalkthroughThis pull request introduces a comprehensive transition from Lerna to Changesets for package versioning and dependency management across the Dojo Engine project. The changes include adding Changeset configuration files, updating GitHub Actions workflows, and renaming example project packages to follow a more consistent naming convention. The primary goal is to streamline the release process and improve package management using the Changesets tool. Changes
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Changesets as Changesets CLI
participant GitHub as GitHub Actions
participant NPM as NPM Registry
Dev->>Changesets: Create changeset
Changesets->>GitHub: Trigger release workflow
GitHub->>GitHub: Validate changes
GitHub->>NPM: Publish packages
NPM-->>Dev: Packages published
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (17)
.changeset/README.md(1 hunks).changeset/config.json(1 hunks).changeset/seven-elephants-serve.md(1 hunks).github/workflows/ci.yaml(1 hunks).github/workflows/docs.yaml(1 hunks).github/workflows/release.yaml(2 hunks)examples/example-nodejs-bot/package.json(1 hunks)examples/example-vanillajs-phaser-recs/package.json(1 hunks)examples/example-vite-kitchen-sink/package.json(1 hunks)examples/example-vite-react-app-recs/package.json(1 hunks)examples/example-vite-react-phaser-recs/package.json(1 hunks)examples/example-vite-react-pwa-recs/package.json(1 hunks)examples/example-vite-react-sdk/package.json(1 hunks)examples/example-vite-react-threejs-recs/package.json(1 hunks)examples/example-vite-svelte-recs/package.json(1 hunks)examples/example-vue-app-recs/package.json(1 hunks)package.json(1 hunks)
✅ Files skipped from review due to trivial changes (13)
- .changeset/README.md
- examples/example-vite-svelte-recs/package.json
- examples/example-nodejs-bot/package.json
- examples/example-vite-react-pwa-recs/package.json
- examples/example-vue-app-recs/package.json
- examples/example-vite-react-phaser-recs/package.json
- .changeset/config.json
- examples/example-vanillajs-phaser-recs/package.json
- examples/example-vite-kitchen-sink/package.json
- examples/example-vite-react-threejs-recs/package.json
- examples/example-vite-react-app-recs/package.json
- examples/example-vite-react-sdk/package.json
- .changeset/seven-elephants-serve.md
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: check
🔇 Additional comments (6)
package.json (2)
9-9: Review the use of--forceflag in the release scriptThe
--forceflag in the publish command can be risky as it bypasses version checks. Consider removing it unless there's a specific need.
14-17: Verify removal of commitlint and import sortingThe removal of
@commitlintpackages and@ianvs/prettier-plugin-sort-importsmight affect commit message validation and import sorting. Please confirm if these features are still needed..github/workflows/docs.yaml (1)
21-21: LGTM! pnpm version update is consistentThe update to pnpm v10.0.0 is consistent with other workflow files.
.github/workflows/release.yaml (2)
Line range hint
4-8: Verify if release_type input is still usedThe workflow_dispatch input
release_typeappears to be unused after switching to changesets. Consider removing it if not needed.
42-49: LGTM! Changesets action configurationThe changesets action is properly configured with the necessary environment variables and publish command.
.github/workflows/ci.yaml (1)
17-17: LGTM! pnpm version update is consistentThe update to pnpm v10.0.0 is consistent with other workflow files.
| "dependencies": { | ||
| "@changesets/cli": "^2.27.11" |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Move @changesets/cli to devDependencies
The @changesets/cli package is a development tool and should be in devDependencies instead of dependencies.
- "dependencies": {
- "@changesets/cli": "^2.27.11"
- }
+ "devDependencies": {
+ "@changesets/cli": "^2.27.11",
+ ...existing devDependencies...
+ }Committable suggestion skipped: line range outside the PR's diff.
Summary by CodeRabbit
Chores
Dependencies
@changesets/cli@commitlint/cliand@ianvs/prettier-plugin-sort-importsConfiguration