-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump to cairo 2.9.2 #2879
Merged
Merged
Changes from 20 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
d5038b6
wip: deps versionning
glihm 83bf801
fix: add missing scarb field
glihm 1fb3e30
chore: bump scarb
glihm 4a3ade9
fix blockifier changes
kariy 4ce7374
fix: update scarb related code for testing
glihm b60db4c
fix blockifier resource bounds mapping
kariy 60d43dd
Merge branch 'main' into feat/cairo-291
kariy 3126333
bump scarb version
kariy e380dda
cairo fmt
kariy 5e77d22
tests: regenerate test databases
glihm e71beff
fix: bump cainome to fix event parsing
glihm 914af81
fix: clippy
glihm fdd0956
fix contract call
kariy 1deee22
add test for calling non legacy contract
kariy 318571a
wip: fixing cairo compilation
glihm 0f5b8c0
merge main
glihm 4c3c27b
chore: bump to cairo 2.9.2
glihm c04cdc6
chore: update scarb
glihm 443f034
fix: fmt and scarb update
glihm 9f0d3c4
tests: regenerates test dbs
glihm 60f97aa
fix: migrate to new scarb test functions
glihm 68680d6
tests: regenerate test db
glihm 2fb4521
merge main
glihm ce9a8e9
tests: regenerate test db
glihm 7415519
ci: add scarb for test commands since it depends on scarb metadata
glihm 703a066
fix(core-cairo-test): build external world class and adjust panick me…
glihm 58007e2
feat: don't enforce fee if tx max fee is zero
kariy b4bf759
merge main
glihm 972c147
chore: bump scarb
glihm d3e8aba
fix: add better error message if env var SCARB is not correctly set
glihm 0872858
tests: regenerate test db and update addresses in cairo config
glihm b559ab2
only modify if we're in fee enabled mode
kariy 545cc07
tests: fix test policies
glihm 231b228
ci: use rust 181 devcontainer
glihm 27d499a
tests: regenerate test db
glihm 9f0efd1
ci: wip
glihm 64d0877
ci+docker: move to ubuntu:noble
glihm 4b2a7c0
merge main
glihm c4ba5bf
ci: add back dojo-dev image for test
glihm 767be0f
merge main
glihm 6fbdccf
ci: add the container to build for the same version
glihm ef8ec48
docker: add make to devcontainer
glihm 3500f1d
ci: use latest dojo-dev
glihm 44c0358
docker: revert to bookworm for dojo image
glihm f3cced0
fix(devcontainer): add missing dependencies for testing
glihm 3bccc10
ci: bump devcontainer
glihm 81d1a02
tests: regenerate test db
glihm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| scarb 2.8.4 | ||
| scarb 2.9.2 | ||
| starknet-foundry 0.30.0 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Heads up sensei! Version mismatch detected.
The Scarb version (2.9.1) in the CI workflow is behind the Cairo version (2.9.2) used in dependencies. Consider updating to 2.9.2 for consistency.
Apply this diff to align versions:
📝 Committable suggestion