Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release: v1.0.11 #2908

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Prepare release: v1.0.11 #2908

merged 1 commit into from
Jan 14, 2025

Conversation

tarrencev
Copy link
Contributor

@tarrencev tarrencev commented Jan 14, 2025

Automated changes by create-pull-request GitHub action

Summary by CodeRabbit

  • Release
    • Incremented package version from 1.0.10 to 1.0.11 across multiple project configuration files
    • Version update applies to Cargo.toml and Scarb.toml files in various project locations

Copy link

coderabbitai bot commented Jan 14, 2025

Walkthrough

Ohayo, sensei! This pull request involves a straightforward version bump across multiple Rust project configuration files. The version number is consistently updated from "1.0.10" to "1.0.11" in the Cargo.toml and various Scarb.toml files across different project directories. This appears to be a standard release increment that maintains version consistency throughout the project's components.

Changes

File Change Summary
Cargo.toml Version updated from "1.0.10" to "1.0.11"
crates/dojo/core/Scarb.toml Version updated from "1.0.10" to "1.0.11"
crates/torii/types-test/Scarb.toml Version updated from "1.0.10" to "1.0.11"
examples/spawn-and-move/Scarb.toml Version updated from "1.0.10" to "1.0.11"

Possibly related PRs

Suggested reviewers

  • glihm

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c54c427 and cae0df2.

⛔ Files ignored due to path filters (4)
  • Cargo.lock is excluded by !**/*.lock
  • crates/dojo/core/Scarb.lock is excluded by !**/*.lock
  • crates/torii/types-test/Scarb.lock is excluded by !**/*.lock
  • examples/spawn-and-move/Scarb.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • Cargo.toml (1 hunks)
  • crates/dojo/core/Scarb.toml (1 hunks)
  • crates/torii/types-test/Scarb.toml (1 hunks)
  • examples/spawn-and-move/Scarb.toml (1 hunks)
✅ Files skipped from review due to trivial changes (3)
  • examples/spawn-and-move/Scarb.toml
  • crates/dojo/core/Scarb.toml
  • crates/torii/types-test/Scarb.toml
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: fmt
🔇 Additional comments (2)
Cargo.toml (2)

Line range hint 279-281: Ohayo sensei! Consider addressing the TODO comment.

There's a TODO comment regarding the git version of ipfs-api-backend-hyper. Consider evaluating if this dependency can be updated to use a published version instead of a git dependency.

Let's check if there's a published version available:


63-63: Ohayo sensei! Version bump looks good, but let's verify consistency.

The version bump from 1.0.10 to 1.0.11 appears correct. However, we should ensure version consistency across all related files.

Let's verify the version consistency across all Scarb.toml files:

Also, let's verify that no internal workspace dependencies specify explicit versions:


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.24%. Comparing base (c54c427) to head (cae0df2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2908      +/-   ##
==========================================
- Coverage   56.05%   55.24%   -0.82%     
==========================================
  Files         449      449              
  Lines       57927    58321     +394     
==========================================
- Hits        32473    32219     -254     
- Misses      25454    26102     +648     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm
Copy link
Collaborator

glihm commented Jan 14, 2025

waiting #2909 to avoid painful upgrade for every patch.

@glihm glihm merged commit 2c77db4 into main Jan 14, 2025
14 of 15 checks passed
@glihm glihm deleted the prepare-release branch January 14, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants