Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rm saya #2951

Merged
merged 1 commit into from
Jan 24, 2025
Merged

chore: rm saya #2951

merged 1 commit into from
Jan 24, 2025

Conversation

kariy
Copy link
Member

@kariy kariy commented Jan 24, 2025

All of saya has been moved to its own repo https://github.com/dojoengine/saya

Summary by CodeRabbit

  • Workspace Configuration

    • Removed several members from the workspace, including bin/saya, bin/scheduler, crates/saya/core, and crates/saya/provider
  • Removal of Components

    • Deleted Saya settlement service components
    • Removed Scheduler binary and associated files
    • Eliminated Saya core and provider crates
  • Documentation

    • Removed README files and documentation for Saya and Scheduler components

This appears to be a significant cleanup and removal of specific components related to Saya and Scheduler from the project workspace.

Copy link

coderabbitai bot commented Jan 24, 2025

Walkthrough

The pull request involves a comprehensive removal of the Saya settlement service and related components from the project workspace. Multiple files and directories associated with the Saya implementation, including binaries, core libraries, and provider modules, have been completely deleted. This removal simplifies the workspace configuration by eliminating unused or deprecated components related to blockchain state management and proof generation.

Changes

File/Directory Change Summary
Cargo.toml Removed workspace members: "bin/saya", "bin/scheduler", "crates/saya/core", "crates/saya/provider"
bin/saya/ Entire directory removed, including Cargo configuration, README, scripts, source code
bin/scheduler/ Entire directory removed, including Cargo configuration, README, source code
crates/saya/core/ Entire directory removed, including source code for core functionality
crates/saya/provider/ Entire directory removed, including source code for data providers

Possibly related PRs

Ohayo, sensei! 🍵 Looks like we've done a massive cleanup of the Saya components. The workspace is now leaner and meaner! 🚀


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 894478e and ad1665a.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (46)
  • Cargo.toml (0 hunks)
  • bin/saya/Cargo.toml (0 hunks)
  • bin/saya/README.md (0 hunks)
  • bin/saya/programs/cairo1echo.json (0 hunks)
  • bin/saya/saya.sh (0 hunks)
  • bin/saya/scripts/0_account_setup.sh (0 hunks)
  • bin/saya/scripts/1_world_setup.sh (0 hunks)
  • bin/saya/scripts/2_world_config.sh (0 hunks)
  • bin/saya/scripts/3_piltover.sh (0 hunks)
  • bin/saya/src/args/data_availability.rs (0 hunks)
  • bin/saya/src/args/mod.rs (0 hunks)
  • bin/saya/src/args/proof.rs (0 hunks)
  • bin/saya/src/args/settlement.rs (0 hunks)
  • bin/saya/src/args/starknet_account.rs (0 hunks)
  • bin/saya/src/args/test_saya_config_file.json (0 hunks)
  • bin/saya/src/main.rs (0 hunks)
  • bin/scheduler/Cargo.toml (0 hunks)
  • bin/scheduler/README.md (0 hunks)
  • bin/scheduler/src/main.rs (0 hunks)
  • crates/saya/README.md (0 hunks)
  • crates/saya/core/Cargo.toml (0 hunks)
  • crates/saya/core/src/blockchain/mod.rs (0 hunks)
  • crates/saya/core/src/data_availability/celestia/mod.rs (0 hunks)
  • crates/saya/core/src/data_availability/error.rs (0 hunks)
  • crates/saya/core/src/data_availability/mod.rs (0 hunks)
  • crates/saya/core/src/dojo_os/mod.rs (0 hunks)
  • crates/saya/core/src/dojo_os/piltover.rs (0 hunks)
  • crates/saya/core/src/error.rs (0 hunks)
  • crates/saya/core/src/lib.rs (0 hunks)
  • crates/saya/core/src/macros.rs (0 hunks)
  • crates/saya/core/src/prover/client.rs (0 hunks)
  • crates/saya/core/src/prover/loader.rs (0 hunks)
  • crates/saya/core/src/prover/mod.rs (0 hunks)
  • crates/saya/core/src/prover/persistent.rs (0 hunks)
  • crates/saya/core/src/prover/program_input.rs (0 hunks)
  • crates/saya/core/src/verifier/mod.rs (0 hunks)
  • crates/saya/core/src/verifier/starknet.rs (0 hunks)
  • crates/saya/core/src/verifier/utils.rs (0 hunks)
  • crates/saya/provider/Cargo.toml (0 hunks)
  • crates/saya/provider/src/error.rs (0 hunks)
  • crates/saya/provider/src/lib.rs (0 hunks)
  • crates/saya/provider/src/provider.rs (0 hunks)
  • crates/saya/provider/src/rpc/mod.rs (0 hunks)
  • crates/saya/provider/src/rpc/state.rs (0 hunks)
  • crates/saya/provider/src/rpc/state_diff.rs (0 hunks)
  • crates/saya/provider/src/rpc/transaction.rs (0 hunks)
💤 Files with no reviewable changes (46)
  • bin/scheduler/Cargo.toml
  • crates/saya/provider/src/rpc/state_diff.rs
  • bin/saya/Cargo.toml
  • bin/saya/scripts/2_world_config.sh
  • crates/saya/core/src/macros.rs
  • crates/saya/README.md
  • bin/saya/src/args/test_saya_config_file.json
  • bin/saya/scripts/0_account_setup.sh
  • bin/scheduler/README.md
  • crates/saya/core/src/verifier/mod.rs
  • crates/saya/provider/src/lib.rs
  • bin/saya/src/args/proof.rs
  • crates/saya/provider/src/provider.rs
  • bin/saya/saya.sh
  • bin/saya/src/main.rs
  • crates/saya/core/src/verifier/utils.rs
  • crates/saya/provider/src/error.rs
  • bin/saya/README.md
  • Cargo.toml
  • crates/saya/core/src/error.rs
  • bin/saya/scripts/1_world_setup.sh
  • crates/saya/provider/Cargo.toml
  • crates/saya/core/src/data_availability/error.rs
  • bin/saya/src/args/settlement.rs
  • bin/saya/programs/cairo1echo.json
  • bin/scheduler/src/main.rs
  • crates/saya/core/src/prover/client.rs
  • crates/saya/core/src/dojo_os/mod.rs
  • bin/saya/src/args/data_availability.rs
  • bin/saya/scripts/3_piltover.sh
  • bin/saya/src/args/mod.rs
  • bin/saya/src/args/starknet_account.rs
  • crates/saya/core/Cargo.toml
  • crates/saya/core/src/verifier/starknet.rs
  • crates/saya/core/src/prover/mod.rs
  • crates/saya/core/src/prover/loader.rs
  • crates/saya/core/src/lib.rs
  • crates/saya/core/src/dojo_os/piltover.rs
  • crates/saya/core/src/data_availability/mod.rs
  • crates/saya/provider/src/rpc/state.rs
  • crates/saya/core/src/blockchain/mod.rs
  • crates/saya/provider/src/rpc/mod.rs
  • crates/saya/core/src/prover/persistent.rs
  • crates/saya/provider/src/rpc/transaction.rs
  • crates/saya/core/src/prover/program_input.rs
  • crates/saya/core/src/data_availability/celestia/mod.rs
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: fmt

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.55%. Comparing base (894478e) to head (ad1665a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2951      +/-   ##
==========================================
+ Coverage   55.82%   56.55%   +0.72%     
==========================================
  Files         447      419      -28     
  Lines       57735    55475    -2260     
==========================================
- Hits        32232    31374     -858     
+ Misses      25503    24101    -1402     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarrencev
Copy link
Contributor

RIP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants