Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add puzzle status error #12

Merged
merged 2 commits into from
Feb 20, 2024
Merged

add puzzle status error #12

merged 2 commits into from
Feb 20, 2024

Conversation

dolfolife
Copy link
Owner

Also, added basic test for the Puzzle object while getting unmarshall

Also, added basic test for the Puzzle object while getting unmarshall

Signed-off-by: Rodolfo Sanchez <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (b94a293) 12.76% compared to head (bb49fc4) 17.73%.
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/puzzle/puzzle.go 53.84% 10 Missing and 2 partials ⚠️
pkg/puzzle/puzzle_errors.go 0.00% 7 Missing ⚠️
pkg/math/geometry.go 84.21% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   12.76%   17.73%   +4.96%     
==========================================
  Files           9       10       +1     
  Lines         235      265      +30     
==========================================
+ Hits           30       47      +17     
- Misses        204      212       +8     
- Partials        1        6       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Rodolfo Sanchez <[email protected]>
@dolfolife dolfolife self-assigned this Feb 20, 2024
@dolfolife dolfolife marked this pull request as ready for review February 20, 2024 18:16
@dolfolife dolfolife merged commit b7d76b5 into main Feb 20, 2024
1 check passed
@dolfolife dolfolife deleted the dolfo/get-puzzle-errors branch February 20, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants