Interface: Static Game Window Title option #13137
Conversation
Source/Core/Core/Core.cpp
Outdated
|
|
||
| if (Config::Get(Config::MAIN_STATIC_TITLE)) | ||
| { | ||
| message = "Dolphin Render Window"; |
There was a problem hiding this comment.
This should be translated. (Unless that would be a problem for people who swap between different interface languages, if they need the window title to be static across languages...? But then I would recommend "Dolphin" instead of "Dolphin Render Window".)
| message = "Dolphin Render Window"; | |
| message = GetStringT("Dolphin Render Window"); |
There was a problem hiding this comment.
Thanks for the feedback.
Yes I agree, it should be translated, I overlooked this.
Pikterra32
force-pushed
the
static-game-window-title-option
branch
from
7f94a4a
to
cd12197
Compare
| const bool enabled = m_checkbox_static_title->isChecked(); | ||
|
|
||
| if (enabled) | ||
| m_checkbox_show_active_title->setChecked(false); |
There was a problem hiding this comment.
Please don't uncheck "Show Active Title in Window Title" when "Static Window Title" is enabled, just setting the checkbox state to disabled is enough.
| @@ -353,6 +358,9 @@ void InterfacePane::AddDescriptions() | |||
| QT_TR_NOOP("Shows on-screen display messages over the render window. These messages " | |||
| "disappear after several seconds." | |||
| "<br><br><dolphin_emphasis>If unsure, leave this checked.</dolphin_emphasis>"); | |||
| static constexpr char TR_STATIC_WINDOW_TITLE[] = | |||
| QT_TR_NOOP("The render window's title will always be \"Dolphin Render Window\"." | |||
| "<br><br><dolphin_emphasis>If unsure, leave this unchecked.</dolphin_emphasis>"); | |||
There was a problem hiding this comment.
Settings that disable other settings should mention that in the tooltip, please change this to:
The render window's title will always be \"Dolphin Render Window\".<br><br>If this setting is enabled, Show Active Title in Window Title will be disabled.<br><br><dolphin_emphasis>If unsure, leave this unchecked.</dolphin_emphasis>
| @@ -353,6 +358,9 @@ void InterfacePane::AddDescriptions() | |||
| QT_TR_NOOP("Shows on-screen display messages over the render window. These messages " | |||
| "disappear after several seconds." | |||
| "<br><br><dolphin_emphasis>If unsure, leave this checked.</dolphin_emphasis>"); | |||
| static constexpr char TR_STATIC_WINDOW_TITLE[] = | |||
| QT_TR_NOOP("The render window's title will always be \"Dolphin Render Window\"." | |||
| "<br><br><dolphin_emphasis>If unsure, leave this unchecked.</dolphin_emphasis>"); | |||
| static constexpr char TR_SHOW_ACTIVE_TITLE_DESCRIPTION[] = | |||
| QT_TR_NOOP("Shows the active game title in the render window's title bar." | |||
| "<br><br><dolphin_emphasis>If unsure, leave this checked.</dolphin_emphasis>"); | |||
There was a problem hiding this comment.
Settings that get disabled when other settings are enabled should also mention that, please change this to:
Shows the active game title in the render window's title bar.<br><br>This setting is disabled when Static Window Title is enabled.<br><br><dolphin_emphasis>If unsure, leave this checked.</dolphin_emphasis>
Remade from #13130 because I messed it up.
Implementing Feature Request from https://bugs.dolphin-emu.org/issues/11982 .
Adds a "Static Window Title" checkbox in ( Options->Configuration->Interface ).
This makes the render window title always be "Dolphin Render Window".
If this option is checked, the "Show Active Title in Window Title" checkbox will be unchecked and set to disabled, because the functionality of these two options are incompatible.