Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for importing tsv files #181

Merged
merged 1 commit into from
May 15, 2024

Conversation

tamalign
Copy link
Contributor

@tamalign tamalign commented May 9, 2024

Hello team,

I've added support for importing TSV files in this pull request.

Please review the changes and let me know if there are any issues or further enhancements needed. If you are not accepting contributions at this moment, please inform me and I will close the PR.

Thank you!

@tbantle22
Copy link
Collaborator

Thank you for this contribution! I will review today

@tbantle22 tbantle22 self-requested a review May 15, 2024 16:35
Copy link
Collaborator

@tbantle22 tbantle22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Will merge and get a release out shortly

@tbantle22 tbantle22 merged commit 32737dd into dolthub:main May 15, 2024
2 checks passed
@tbantle22
Copy link
Collaborator

This was released in 0.2.11

@tamalign
Copy link
Contributor Author

@tbantle22
Thank you for the review!

Would it be okay to create several more PRs (e.g., for bug fixes)? If it won't burden your team, I would love to contribute further.

@tamalign tamalign deleted the feature/support_tsv branch May 16, 2024 14:19
@timsehn
Copy link
Contributor

timsehn commented May 16, 2024

Pretty please! Keep em coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants