migrate dolt ls to use sql queries #6834
Conversation
There was a problem hiding this comment.
Very close. The only objection I have at the moment is that we don't test the SQL directly with the new flag. I think a couple enginetests are in order because we are testing it exclusively as a part of dolt ls - there are going to be people who want this in the sql conext so we should test that way
| } | ||
|
|
||
| r, err := cm.GetRootValue(ctx) | ||
|
|
||
| _, _, err = queryist.Query(sqlCtx, "set @@dolt_show_system_tables = 1") |
There was a problem hiding this comment.
Question - does it work if we just put this set call as a prefix on the main query?
"set @@dolt_show_system_tables = 1; show tables ... "
There was a problem hiding this comment.
No they don't work all in one string. I think the way dolt sql -q is set up doesn't allow multiple statements in one call.
There was a problem hiding this comment.
huh. Sounds like a feature we should have. ok. never mind for now!
This change updates
dolt lsto use the appropriate sql engine to generate results. This change also creates a system variable that, when enabled, shows dolt system tables inshow tablesandinformation_schema.tables.Related: #3922
Resolves: #2073