Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make show command more resilient when resolving references #8730

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

macneale4
Copy link
Contributor

@macneale4 macneale4 commented Jan 10, 2025

Currently the show command can print internal objects, which requires a local environment. This goes against the sql migration expectations that there is no environment. This change only makes the situation less bad. Splitting out the admin operations into another command is the right approach.

Fixes: #8727

Currently the show command can print internal object, which requires a local environment.
This goes against the sql migration expectations that there is no environment. This change
only makes the situation less bad. Splitting out the admin operations into another command
is the right approach.
@macneale4 macneale4 requested a review from nicktobey January 10, 2025 19:13
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
d4b2722 ok 5937457
version total_tests
d4b2722 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c6cd6b4 ok 5937457
version total_tests
c6cd6b4 5937457
correctness_percentage
100.0

go/cmd/dolt/commands/show.go Outdated Show resolved Hide resolved
go/cmd/dolt/commands/show.go Outdated Show resolved Hide resolved
integration-tests/bats/show.bats Show resolved Hide resolved
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
6016c4a ok 5937457
version total_tests
6016c4a 5937457
correctness_percentage
100.0

@macneale4 macneale4 merged commit 581c2f9 into main Jan 13, 2025
21 checks passed
@macneale4 macneale4 deleted the macneale4/show-bandaid branch January 13, 2025 01:14
Copy link

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 1.33
batching batch sql 10000 1 0.08 1.5
batching by line sql 10000 1 0.08 1.5
blob 1 blob 200000 1 0.95 3.71 4.41
blob 2 blobs 200000 1 0.94 4.19 4.67
blob no blob 200000 1 1.03 2.1 2.49
col type datetime 200000 1 0.81 2.42 2.74
col type varchar 200000 1 0.76 3.09 3.58
config width 2 cols 200000 1 0.82 2.37 2.67
config width 32 cols 200000 1 1.94 2.01 2.7
config width 8 cols 200000 1 0.96 2.42 2.79
pk type float 200000 1 0.89 2.24 2.54
pk type int 200000 1 0.86 2.47 2.57
pk type varchar 200000 1 2.93 0.86 0.97
row count 1.6mm 1600000 1 5.81 2.83 2.78
row count 400k 400000 1 1.49 2.67 2.8
row count 800k 800000 1 3.01 2.7 2.74
secondary index four index 200000 1 3.67 1.36 1.22
secondary index no secondary 200000 1 0.98 2.22 2.59
secondary index one index 200000 1 1.15 2.37 2.57
secondary index two index 200000 1 2.02 1.75 1.82
sorting shuffled 1mm 1000000 0 5.5 2.66 2.59
sorting sorted 1mm 1000000 1 5.45 2.68 2.6

Copy link

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.19
dolt_blame_commit_filter system table 3.01
dolt_commit_ancestors_commit_filter system table 0.61
dolt_commits_commit_filter system table 0.95
dolt_diff_log_join_from_commit system table 2.93
dolt_diff_log_join_to_commit system table 2.89
dolt_diff_table_from_commit_filter system table 1.21
dolt_diff_table_to_commit_filter system table 1.17
dolt_diffs_commit_filter system table 1.06
dolt_history_commit_filter system table 1.31
dolt_log_commit_filter system table 1.05

Copy link

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.11
adds_updates_deletes 60000 60000 60000 4.51
deletes_only 0 60000 0 2.52
updates_only 0 0 60000 3.07

Copy link

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.07 1.14
batching batch sql 10000 1 0.11 1.09
batching by line sql 10000 1 0.11 1.09
blob 1 blob 200000 1 0.95 3.61 4.29
blob 2 blobs 200000 1 0.89 4.34 4.79
blob no blob 200000 1 0.91 2.38 2.69
col type datetime 200000 1 0.81 2.38 2.64
col type varchar 200000 1 0.75 3.05 3.39
config width 2 cols 200000 1 0.81 2.41 2.74
config width 32 cols 200000 1 1.88 2.02 2.78
config width 8 cols 200000 1 0.98 2.32 2.64
pk type float 200000 1 0.85 2.32 2.52
pk type int 200000 1 0.9 2.13 2.37
pk type varchar 200000 1 1.5 1.66 1.81
row count 1.6mm 1600000 1 5.8 2.8 2.66
row count 400k 400000 1 1.54 2.54 2.61
row count 800k 800000 1 2.88 2.78 2.7
secondary index four index 200000 1 3.65 1.35 1.19
secondary index no secondary 200000 1 0.97 2.22 2.52
secondary index one index 200000 1 1.14 2.36 2.5
secondary index two index 200000 1 2.03 1.72 1.75
sorting shuffled 1mm 1000000 0 5.23 2.67 2.61
sorting sorted 1mm 1000000 1 5.1 2.71 2.69

Copy link

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.19
dolt_blame_commit_filter system table 2.99
dolt_commit_ancestors_commit_filter system table 0.65
dolt_commits_commit_filter system table 1.05
dolt_diff_log_join_from_commit system table 2.92
dolt_diff_log_join_to_commit system table 2.9
dolt_diff_table_from_commit_filter system table 1.21
dolt_diff_table_to_commit_filter system table 1.19
dolt_diffs_commit_filter system table 1.03
dolt_history_commit_filter system table 1.36
dolt_log_commit_filter system table 1.05

Copy link

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.16
adds_updates_deletes 60000 60000 60000 4.53
deletes_only 0 60000 0 2.45
updates_only 0 0 60000 3.05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

\show in SQL shell panics when arg isn't a commit
3 participants