/go/libraries/doltcore/sql/dsess: parallelize sql.NewDatabase work

[coffeegoddd]

No description provided.

[coffeegoddd]

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
fa6c12f	ok	5937457

version	total_tests
fa6c12f	5937457

correctness_percentage
100.0

[coffeegoddd]

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
53ba7ca	ok	5937458

version	total_tests
53ba7ca	5937458

correctness_percentage
100.0

[reltuk]

Instead of a channel here, just allocate roots here:

roots := make([]doltdb.Rootish, len(rootRefs))

and then have the loop capture the iteration variable and write the root into the right place:

for i, b := range rootRefs {
    eg.Go(func() error {
        ...
            roots[i] = cm
        ...
            roots[i] = ws
        ...
    })
}

Probably best to eg.SetLimit() on this errgroup as well.

[reltuk]

LGTM. One suggestion on improving the code.

[coffeegoddd]

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
a819aa2	ok	5937457

version	total_tests
a819aa2	5937457

correctness_percentage
100.0

[coffeegoddd]

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
93355c5	ok	5937457

version	total_tests
93355c5	5937457

correctness_percentage
100.0