Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/libraries/doltcore/sqle/dprocedures: dolt_gc.go: Retry canceling running queries when waiting for safepoint establishment. #8747

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Jan 14, 2025

This allows call dolt_gc() to more quickly and realibly establish a safepoint if the call to safepointF() races with a new query beginning and being registered for the connection in the process list.

…unning queries when waiting for safepoint establishment.

This allows `call dolt_gc()` to more quickly and realibly establish a safepoint
if the call to safepointF() races with a new query beginning and being
registered for the connection in the process list.
@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
8706074 ok 5937457
version total_tests
8706074 5937457
correctness_percentage
100.0

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@reltuk reltuk merged commit d2c94f3 into main Jan 16, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants