Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-release-notes] go/store/nbs: Make CompressedChunk support ghost chunks and make and GhostBlockStore support GetManyCompressed. #8748

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Jan 15, 2025

As part of ongoing work on GC, we are moving the references walk from store/types to be the responsibility of the ChunkStore itself. It is most natural to express it if a generational store's GetManyCompressed can return ghost chunks as well.

…hunks and make and GhostBlockStore support GetManyCompressed.

As part of ongoing work on GC, we are moving the references walk from
store/types to be the responsibility of the ChunkStore itself. It is most
natural to express it if a generational store's GetManyCompressed can return
ghost chunks as well.
@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
f45fa52 ok 5937457
version total_tests
f45fa52 5937457
correctness_percentage
100.0

Copy link
Contributor

@macneale4 macneale4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty reasonable. Tests?

@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
567342b ok 5937457
version total_tests
567342b 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
4e4c446 ok 5937457
version total_tests
4e4c446 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
16788c6 ok 5937457
version total_tests
16788c6 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
ea0fc38 ok 5937457
version total_tests
ea0fc38 5937457
correctness_percentage
100.0

@reltuk reltuk force-pushed the aaron/ghost-compressed-chunks branch from ea0fc38 to 0b17081 Compare January 15, 2025 14:39
@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
0b17081 ok 5937457
version total_tests
0b17081 5937457
correctness_percentage
100.0

@reltuk reltuk merged commit 1681cbd into main Jan 15, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants