-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no-release-notes] go/store/nbs: Make CompressedChunk support ghost chunks and make and GhostBlockStore support GetManyCompressed. #8748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hunks and make and GhostBlockStore support GetManyCompressed. As part of ongoing work on GC, we are moving the references walk from store/types to be the responsibility of the ChunkStore itself. It is most natural to express it if a generational store's GetManyCompressed can return ghost chunks as well.
macneale4
reviewed
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems pretty reasonable. Tests?
macneale4
approved these changes
Jan 15, 2025
…ehavior of GhostBlockStore.
@coffeegoddd DOLT
|
reltuk
force-pushed
the
aaron/ghost-compressed-chunks
branch
from
January 15, 2025 14:39
ea0fc38
to
0b17081
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of ongoing work on GC, we are moving the references walk from store/types to be the responsibility of the ChunkStore itself. It is most natural to express it if a generational store's GetManyCompressed can return ghost chunks as well.