make autoincrement tracker load async #8753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coffeegoddd DOLT
|
zachmu
approved these changes
Jan 15, 2025
| @@ -398,7 +435,20 @@ func (a *AutoIncrementTracker) AcquireTableLock(ctx *sql.Context, tableName stri | |||
| return a.mm.Lock(tableName), nil | |||
| } | |||
|
|
|||
| func (a *AutoIncrementTracker) InitWithRoots(ctx context.Context, roots ...doltdb.Rootish) error { | |||
| func (a *AutoIncrementTracker) waitForInit() error { | |||
| a.wg.Wait() | |||
There was a problem hiding this comment.
Probably want to add a generous timeout here and return a different error if it is surpassed
…ut to ai waitForInit
|
@coffeegoddd DOLT
|
zachmu
reviewed
Jan 16, 2025
| @@ -398,7 +437,31 @@ func (a *AutoIncrementTracker) AcquireTableLock(ctx *sql.Context, tableName stri | |||
| return a.mm.Lock(tableName), nil | |||
| } | |||
|
|
|||
| func (a *AutoIncrementTracker) InitWithRoots(ctx context.Context, roots ...doltdb.Rootish) error { | |||
| func (a *AutoIncrementTracker) waitForInit() error { | |||
| done := make(chan struct{}) | |||
There was a problem hiding this comment.
Probably don't want to initialize a new channel here, this is called a lot.
I think instead I would get rid of the waitgroup entirely (it's just a single work item) and use a channel in the struct, then close the channel instead of calling wg.Done(). Your logic for waiting below still works fine.
|
@coffeegoddd DOLT
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.