Merge pull request #803 from dolthub/taylor/fix-blog

Fix blog tests
dolthub · Apr 18, 2024 · 8ad7842 · 8ad7842
2 parents f46bb69 + 4f15ac5
commit 8ad7842
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/cypress/e2e/dolthub/publicPaths/render/blog/index.spec.ts b/cypress/e2e/dolthub/publicPaths/render/blog/index.spec.ts
@@ -63,6 +63,7 @@ describe(`${pageName} renders expected components on different devices`, () => {
       query1,
       "Getting Started with Dolt and Knex.js",
       "2023-09-27-dolt-and-knexjs/",
+      2,
     ),
     newExpectationWithTypeString(
       "should change input",

diff --git a/cypress/e2e/dolthub/publicPaths/render/blog/query.spec.ts b/cypress/e2e/dolthub/publicPaths/render/blog/query.spec.ts
@@ -35,6 +35,7 @@ describe(`${pageName} renders expected components on different devices`, () => {
       query,
       "Getting Started with Dolt and Knex.js",
       "2023-09-27-dolt-and-knexjs/",
+      2,
     ),
     newExpectationWithClickFlow(
       "should clear search",

diff --git a/cypress/e2e/utils/sharedTests/blog.ts b/cypress/e2e/utils/sharedTests/blog.ts
@@ -15,6 +15,7 @@ export const testSearched = (
   q: string,
   title: string,
   path: string,
+  numMatching = 1,
 ): Expectation[] => [
   newExpectationWithURL(
     "should route to query page",
@@ -25,12 +26,15 @@ export const testSearched = (
   newExpectation(
     "should have matching articles message",
     "[data-cy=matching-articles]",
-    newShouldArgs("be.visible.and.contain", "Found 1 matching article."),
+    newShouldArgs(
+      "be.visible.and.contain",
+      `Found ${numMatching} matching article${numMatching > 1 ? "s" : ""}.`,
+    ),
   ),
   newExpectation(
     "should have one blog",
     "[data-cy=blog-list] > li",
-    newShouldArgs("be.visible.and.have.length", 1),
+    newShouldArgs("be.visible.and.have.length", numMatching),
   ),
   newExpectation(
     `should have matching blog title for ${q}`,