-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix casing of enum keys in a dictionary with CamelCasePropertyNamesContractResolver #3039
Open
j2ghz
wants to merge
9
commits into
domaindrivendev:master
Choose a base branch
from
j2ghz:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5430a09
Add a test for enums in a dictionary with CamelCasePropertyNamesContr…
j2ghz a038da1
Fix by actually running the key names through the serializer
j2ghz cba60ad
Remove replaced code to make the diff more clear
j2ghz 8aec3b7
Merge remote-tracking branch 'upstream/master'
j2ghz 8172fb0
Update src/Swashbuckle.AspNetCore.Newtonsoft/SchemaGenerator/Newtonso…
j2ghz 6d1e306
Update test/Swashbuckle.AspNetCore.Newtonsoft.Test/SchemaGenerator/Ne…
j2ghz 4f78c20
Merge branch 'master' of github.com:j2ghz/Swashbuckle.AspNetCore
j2ghz 13d3fd7
Fix dictionaries with camelCase serialization in STJ
j2ghz bf87f91
Simplify Newtonsoft test, rename JTS test
j2ghz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1131,6 +1131,17 @@ public void GenerateSchema_HonorsEnumDictionaryKeys_StringEnumConverter() | |
Assert.Equal(typeof(IntEnum).GetEnumNames(), referenceSchema.Properties.Keys); | ||
} | ||
|
||
[Fact] | ||
public void GenerateSchema_HonorsEnumDictionaryKeys_StringEnumConverter_CamelCase() | ||
{ | ||
var subject = Subject(null, o => o.DictionaryKeyPolicy = JsonNamingPolicy.CamelCase); | ||
var schemaRepository = new SchemaRepository(); | ||
|
||
var referenceSchema = subject.GenerateSchema(typeof(Dictionary<IntEnum, string>), schemaRepository); | ||
|
||
Assert.Equal(typeof(IntEnum).GetEnumNames().Select(n => n.ToCamelCase()), referenceSchema.Properties.Keys); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would prefer the expected values here are hard-coded, rather than using logic to compute them. |
||
} | ||
|
||
[Fact] | ||
public void GenerateSchema_HonorsSerializerAttribute_StringEnumConverter() | ||
{ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.