Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Properties whenever there are objects without schema(Not onl… #3095

Conversation

jgarciadelanoceda
Copy link
Contributor

Fixes #3094

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.50%. Comparing base (9fa161b) to head (b74ce2a).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3095      +/-   ##
==========================================
- Coverage   90.50%   90.50%   -0.01%     
==========================================
  Files          76       76              
  Lines        3118     3116       -2     
  Branches      516      515       -1     
==========================================
- Hits         2822     2820       -2     
  Misses        296      296              
Flag Coverage Δ
Linux 90.50% <100.00%> (-0.01%) ⬇️
Windows 90.50% <100.00%> (-0.01%) ⬇️
macOS 90.50% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello added this to the v6.8.2 milestone Oct 2, 2024
@martincostello martincostello merged commit c051ca6 into domaindrivendev:master Oct 2, 2024
9 checks passed
@jgarciadelanoceda jgarciadelanoceda deleted the issue_3094_FromFormParametersWithoutSchemaMustHaveProperties branch October 2, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: [FromForm] does not generate a property in schema but makes itself the schema
3 participants