Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FromForm without WithOpenApi schemas #3133

Conversation

jgarciadelanoceda
Copy link
Contributor

Fixes #3126.
Also I have found that there was an error for WithOpenApi for FromFormParameters that are enums

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.55%. Comparing base (0554326) to head (ec2e87f).
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3133      +/-   ##
==========================================
+ Coverage   91.44%   91.55%   +0.10%     
==========================================
  Files          76       76              
  Lines        3121     3125       +4     
  Branches      520      526       +6     
==========================================
+ Hits         2854     2861       +7     
+ Misses        267      264       -3     
Flag Coverage Δ
Linux 81.90% <98.30%> (+0.05%) ⬆️
Windows 91.55% <100.00%> (+0.10%) ⬆️
macOS 91.55% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…hemas similar between MinimalApi and Controllers
@jgarciadelanoceda jgarciadelanoceda marked this pull request as ready for review November 8, 2024 01:52
@jgarciadelanoceda jgarciadelanoceda changed the title Fix the error and also an encountered error for Enums for WithOpenApi… Fix FromForm without WithOpenApi schemas Nov 8, 2024
@martincostello martincostello added this to the v7.0.0 milestone Nov 8, 2024
@martincostello martincostello added bug fix version-major A change suitable for release in a major version labels Nov 8, 2024
@martincostello
Copy link
Collaborator

Thanks - will merge this after #3007.

Javier García de la Noceda Argüelles added 2 commits November 8, 2024 16:10
@jgarciadelanoceda
Copy link
Contributor Author

jgarciadelanoceda commented Nov 8, 2024

We may need to create an issue to check the order of filters to avoid this behaviour but I applied here.. I can remove it if you like and address it on other PR.. But I did not know why the Description did not show up. First filter wins?

@martincostello
Copy link
Collaborator

First filter wins?

Probably. I did similar things in my new OpenAPI extensions NuGet package to not overwrite things in the OpenAPI document if they already had a value.

@martincostello martincostello merged commit c9ae556 into domaindrivendev:master Nov 12, 2024
9 checks passed
@jgarciadelanoceda jgarciadelanoceda deleted the issue_3126_WrongForFromForMinimalApi branch November 13, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix version-major A change suitable for release in a major version
Projects
None yet
3 participants