QiHDWallet: add new method signature for sendTransaction() using paymentCodes #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejoacosta74
force-pushed
the
paymentcodes.v8
branch
from
0153a4f to
725d391
Compare
Comment on lines
+246
to
+266
| public async sendTransaction(tx: QiTransactionRequest): Promise<TransactionResponse>; | ||
|
|
||
| /** | ||
| * Sends a transaction using payment codes and specific parameters. | ||
| * | ||
| * @param recipientPaymentCode The payment code of the recipient. | ||
| * @param amount The amount to send. | ||
| * @param originZone The origin zone of the transaction. | ||
| * @param destinationZone The destination zone of the transaction. | ||
| */ | ||
| public async sendTransaction( | ||
| recipientPaymentCode: string, | ||
| amount: bigint, | ||
| originZone: Zone, | ||
| destinationZone: Zone, | ||
| ): Promise<TransactionResponse>; | ||
|
|
||
| /** | ||
| * Implementation of the sendTransaction method. | ||
| */ | ||
| public async sendTransaction(...args: any[]): Promise<TransactionResponse> { |
There was a problem hiding this comment.
Instead of overloading the sendTransaction method I think it would be better to change the QiTransactionRequest to be our desired form of a transaction request which is recipientPaymentCode, amount, originZone, destinationZone.
There was a problem hiding this comment.
As agreed, lets save the suggested change for future optimizations, since modifying QiTransactionRequest impacts several files.
rileystephens28
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.