Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Qi private key export #345

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Fix Qi private key export #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/wallet/qi-hdwallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,8 +916,18 @@ export class QiHDWallet extends AbstractHDWallet {
*/
private getPrivateKeyForTxInput(input: TxInput): string {
if (!input.pubkey) throw new Error('Missing public key for input');

const address = computeAddress(input.pubkey);
return this.getPrivateKey(address);
}

/**
* Returns the private key for a given address. This method should be used with caution as it exposes the private
* key to the user.
*
* @param {string} address - The address associated with the desired private key.
* @returns {string} The private key.
*/
public getPrivateKey(address: string): string {
const addressInfo = this.locateAddressInfo(address);

if (!addressInfo) {
Expand Down
Loading