Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second try. Merged Docker update. #414

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Second try. Merged Docker update. #414

merged 6 commits into from
Oct 3, 2024

Conversation

DaanSelen
Copy link
Collaborator

No description provided.

@donaldzou
Copy link
Owner

Yeye, will merge now

@DaanSelen DaanSelen mentioned this pull request Oct 3, 2024
Closed
@DaanSelen
Copy link
Collaborator Author

Let's move slowly :) and carefully.

@donaldzou
Copy link
Owner

GitHub mentioned it can merge automatically so I just merged your previous PR lol

@donaldzou
Copy link
Owner

Just resolved the conflicts on Dockerfile, @DaanSelen could u check if is good?

@DaanSelen
Copy link
Collaborator Author

I am going to debug and come back to this once its done (today).

@donaldzou
Copy link
Owner

Sure, no rush ;)

@DaanSelen DaanSelen merged commit 392a9c6 into donaldzou:main Oct 3, 2024
3 checks passed
@DaanSelen
Copy link
Collaborator Author

@donaldzou Verify if nothing got lost or anything?

And if you'd like you can run it in docker with
docker build . -t <image-name> and then docker run -d <image-name>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldzou donaldzou donaldzou approved these changes

Assignees

@donaldzou donaldzou

@DaanSelen DaanSelen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaanSelen @donaldzou