Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating little aspects #420

Closed
wants to merge 12 commits into from
Closed

Updating little aspects #420

wants to merge 12 commits into from

Conversation

DaanSelen
Copy link
Collaborator

@DaanSelen DaanSelen commented Oct 8, 2024

Fixing: #376
Fixing: #408

Added automatic Docker building (ONCE THE GITHUB SECRETS ARE SETUP) @donaldzou :)
Added "Basic wg-dashboard.ini" file so there is no need to start-stop-start WGDashboard to generate the file.

Streamlined some Dockerfile, Compose and Entrypoint files.

@DaanSelen DaanSelen added the enhancement New feature or request label Oct 8, 2024
@DaanSelen
Copy link
Collaborator Author

Hi Donald, please look through the changes carefully. Hopefully you agree with the choices.

@donaldzou
Copy link
Owner

Hi Daan, all the Docker related are good. Regarding the .vue I will need to change it on my side and build it so end user can view the changes on their side. I'm also intended to leave out a pre-generated wg-dashboard.ini file as it will overwrite user's existing one whenever they do an update, so maybe remove it from the PR :)

@DaanSelen
Copy link
Collaborator Author

DaanSelen commented Oct 9, 2024

Hi Daan, all the Docker related are good. Regarding the .vue I will need to change it on my side and build it so end user can view the changes on their side. I'm also intended to leave out a pre-generated wg-dashboard.ini file as it will overwrite user's existing one whenever they do an update, so maybe remove it from the PR :)

I'll remove the vue changes back, so you can do that. But regarding the wg-dashboard.ini:

  • Currently the docker container sets some values inside the container to make usability easier. But to do that it needs a wg-dashboard.ini file to write the changes to. At the moment it does that with starting the WGDashboard service, stopping it, modifying it and then restarting it, which in my opinion is a bit inefficient. What is your work-around perhaps?

@DaanSelen DaanSelen closed this Oct 10, 2024
@DaanSelen DaanSelen mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants