-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified GitHub workflows #430
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Hi Daan, sorry for the late reply as I'm traveling lately. Just wondering for this change, if I understand correctly, it will automatically build and push to Docker Hub? If that so, what would need from my side? Thanks again on the hard work! |
Hi Donald, This has 3 workflows:
What I need for the docker heb push are GitHub secrets. You can create these here on the website. Under Repo -> Environment secrets. These must be the docker hub name and pass. CodeQL I updated the versions because the current ones are deprecated (v1). |
Hi Daan, both secrets are set. Let me know if you think is ready to merge and we can try it out. |
Yes just let me know which account you want to push it to, like what is the name? Mine would be dselen. But your secrets belong to something like Dzou? |
Yes, my account should be |
Hi @donaldzou , then it should be done now. Please verify if you agree. And if the DOCKER_HUB_USERNAME and DOCKER_HUB_PASSWORD are inside the repo. You can verify inside another branch if you'd like. Create like workflow test, before merging into main. |
@donaldzou merge at will, it merges into another branch |
@donaldzou please look into the branch 4.1-dev-workflows (or similar) and if you agree, you can merge it into main. |
It looks good, will merge now and fingers crossed lol |
Everything works! thank u! btw, how do i set an overview on the docker hub page? is there a |
Perhaps the README.md in the docker folder? With some modifications. I'll look into that, but I still need to do the language I promised. |
Added Docker building and analyzing.
For this to work you NEED to add Github secrets and modify the image names so it reflects is well.
Please contact for more info.