Add additional identification guards to Sourceror.Identifier
#108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the lower-level parts of #105.
This PR adds the following guards:
is_call/1
is_unqualified_call/1
is_qualified_call/1
is_identifier/1
is_atomic_literal/1
Additional changes/fixes:
**
) to the list of binary ops for Elixir 1.13+SourcerorTest.Support.Corpus
somewhat to make its use a bit more ergonomictest/corpus/term/alias.ex
(it wasn't erroring because S-expressions are also valid Elixir)While working on this, I realized that these lower-level primitives might prove sufficient for the vast majority of cases. The higher-level things discussed in #105 are likely still useful, but I'd kind of like to kick the tires on these changes before introducing additional new API.