Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize authentication failure #1761

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Memoize authentication failure #1761

merged 1 commit into from
Jan 23, 2025
+4 −1

Conversation

c960657
Copy link
Contributor

@c960657 c960657 commented Jan 17, 2025

Doorkeeper::Rails::Helpers#doorkeeper_token uses memoization, but only when authentication is successful (positive hits).

Let it memoize authentication failures as well.

nbulaj
nbulaj approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@nbulaj nbulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks 🙇

Can we please add a changelog entry and squash the commits? Thanks!

@c960657 c960657 force-pushed the memoize-authentication-failure branch from 9a56d43 to baf936f Compare January 22, 2025 10:35
@nbulaj nbulaj merged commit 884e648 into doorkeeper-gem:main Jan 23, 2025
21 checks passed
@c960657 c960657 deleted the memoize-authentication-failure branch January 24, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbulaj nbulaj nbulaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c960657 @nbulaj