Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare to last commit in a PR when using git commands #209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mirpedrol
Copy link

Close #205
Follow-up from #133

@dorny
Copy link
Owner

dorny commented Feb 15, 2024

@mirpedrol The #133 is merged now. Does it solve also your issue?
Fix in your PR might be working for you, but modifying getCurrentRef() to use HEAD^2 doesn't look correct. Although I haven't tried it myself.

@mirpedrol
Copy link
Author

Thanks for merging #133!
The fix in #133 allowed us to use this action without using the API, but we still have the problem of detecting too many files changed.
This happens because the last commit on PR events is the pre-merge commit, so it includes files that are not modifyed by the current PR.
Would there be a better way to prevent that without having to use HEAD^2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changed files with git commands detects too many files
2 participants