Skip to content

Commit

Permalink
CI: Remove deprecated application
Browse files Browse the repository at this point in the history
  • Loading branch information
khronokernel committed Feb 15, 2025
1 parent bb71553 commit 653f7cc
Show file tree
Hide file tree
Showing 8 changed files with 4 additions and 133 deletions.
28 changes: 1 addition & 27 deletions .github/workflows/build-app-wxpython.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: CI - Build wxPython

on:
push:
paths-ignore:
paths-ignore:
- 'docs/**'
workflow_dispatch:
release:
Expand Down Expand Up @@ -84,23 +84,6 @@ jobs:
--run-as-individual-steps
--prepare-package
- name: Prepare Update Shim (--prepare-shim)
run: >
/Library/Frameworks/Python.framework/Versions/3.11/bin/python3 Build-Project.command
--application-signing-identity "${{ env.ORG_MAC_DEVELOPER_ID_APPLICATION_IDENTITY }}"
--notarization-apple-id "${{ env.ORG_MAC_NOTARIZATION_APPLE_ID }}" --notarization-password "${{ env.ORG_MAC_NOTARIZATION_PASSWORD }}" --notarization-team-id "${{ env.ORG_MAC_NOTARIZATION_TEAM_ID }}"
--run-as-individual-steps
--prepare-shim
- name: Prepare App for Upload
run: /bin/mv ./dist/OpenCore-Patcher.app.zip ./OpenCore-Patcher-GUI.app.zip

- name: Upload App to Artifacts
uses: actions/upload-artifact@v4
with:
name: OpenCore-Patcher.app (GUI)
path: OpenCore-Patcher-GUI.app.zip

- name: Upload AutoPkg Package to Artifacts
uses: actions/upload-artifact@v4
with:
Expand All @@ -119,15 +102,6 @@ jobs:
name: OpenCore-Patcher-Uninstaller.pkg
path: ./dist/OpenCore-Patcher-Uninstaller.pkg

- name: Upload Binary to Release
if: github.event_name == 'release'
uses: svenstaro/upload-release-action@e74ff71f7d8a4c4745b560a485cc5fdb9b5b999d
with:
repo_token: ${{ secrets.GITHUB_TOKEN }}
file: OpenCore-Patcher-GUI.app.zip
tag: ${{ github.ref }}
file_glob: true

- name: Upload AutoPkg Package to Release
if: github.event_name == 'release'
uses: svenstaro/upload-release-action@e74ff71f7d8a4c4745b560a485cc5fdb9b5b999d
Expand Down
35 changes: 1 addition & 34 deletions Build-Project.command
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,16 @@ import os
import sys
import time
import argparse
import plistlib

from pathlib import Path

from ci_tooling.build_modules import (
application,
disk_images,
package,
sign_notarize,
shim
sign_notarize
)

from opencore_legacy_patcher import constants


def main() -> None:
"""
Expand Down Expand Up @@ -55,10 +51,6 @@ def main() -> None:
parser.add_argument("--prepare-package", action="store_true", help="CI: Prepare Package", default=False)
parser.add_argument("--prepare-assets", action="store_true", help="CI: Prepare Assets", default=False)

# CI/CD Parameters for additional steps
# If not specified, will not run additional steps
parser.add_argument("--prepare-shim", action="store_true", help="CI: Prepare Update Shim", default=False)

# Analytics Parameters
parser.add_argument("--analytics-key", type=str, help="Analytics Key", default=None)
parser.add_argument("--analytics-endpoint", type=str, help="Analytics Endpoint", default=None)
Expand Down Expand Up @@ -136,31 +128,6 @@ def main() -> None:
notarization_team_id=args.notarization_team_id,
).sign_and_notarize()

# Create Update Shim
if args.prepare_shim:
shim.GenerateShim().generate()
if Path("dist/OpenCore-Patcher.app").exists():
if Path("dist/OpenCore-Patcher (Original).app").exists():
Path("dist/OpenCore-Patcher (Original).app").unlink()
Path("dist/OpenCore-Patcher.app").rename("dist/OpenCore-Patcher (Original).app")
Path("dist/OpenCore-Patcher (Shim).app").rename("dist/OpenCore-Patcher.app")

# Update app version in Info.plist
plist_path = Path("dist/OpenCore-Patcher.app/Contents/Info.plist")
contents = plistlib.load(plist_path.open("rb"))
contents["CFBundleVersion"] = constants.Constants().patcher_version
contents["CFBundleShortVersionString"] = constants.Constants().patcher_version
plistlib.dump(contents, plist_path.open("wb"))

sign_notarize.SignAndNotarize(
path=Path("dist/OpenCore-Patcher.app"),
signing_identity=args.application_signing_identity,
notarization_apple_id=args.notarization_apple_id,
notarization_password=args.notarization_password,
notarization_team_id=args.notarization_team_id,
entitlements=Path("./ci_tooling/entitlements/entitlements.plist"),
).sign_and_notarize()


if __name__ == '__main__':
_start = time.time()
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
## 2.3.0
- Disable crash analytics
- Disabled server side for years, removing client side
- `OpenCore-Patcher-GUI.app.zip` removed from release
- Deprecated in 1.5.0, use `OpenCore-Patcher.pkg` for installation

## 2.2.0
- Resolved non-metal accessibility zoom on macOS Sonoma/Sequoia
Expand Down
34 changes: 0 additions & 34 deletions ci_tooling/build_modules/shim.py

This file was deleted.

30 changes: 0 additions & 30 deletions ci_tooling/update_shim/OpenCore-Patcher.app/Contents/Info.plist

This file was deleted.

Binary file not shown.
Binary file not shown.
8 changes: 0 additions & 8 deletions ci_tooling/update_shim/README.md

This file was deleted.

0 comments on commit 653f7cc

Please sign in to comment.