Membership #1153
Draft
Membership #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
junlarsen
requested changes
Feb 11, 2025
Comment on lines
+11
to
+13
| } | ||
|
|
||
|
|
Comment on lines
-27
to
+36
| "dev": "pnpm -rc -F @dotkomonline/web -F @dotkomonline/dashboard -F @dotkomonline/rpc -F @dotkomonline/invoicification -F @dotkomonline/rif exec doppler run --preserve-env pnpm run dev", | ||
| "migrate": "pnpm -rc -F @dotkomonline/migrator exec doppler run --preserve-env pnpm run migrate", | ||
| "migrate-down": "pnpm -rc -F @dotkomonline/migrator exec doppler run --preserve-env pnpm run migrate -- down", | ||
| "migrate-down-all": "pnpm -rc -F @dotkomonline/migrator exec doppler run --preserve-env pnpm run migrate", | ||
| "migrate-with-fixtures": "pnpm -rc -F @dotkomonline/migrator exec doppler run --preserve-env pnpm run migrate latest --with-fixtures", | ||
| "migrate-with-sample-data": "pnpm -rc -F @dotkomonline/migrator exec doppler run --preserve-env pnpm run migrate -- latest --sample-data", | ||
| "dev": "pnpm -rc -F @dotkomonline/web -F @dotkomonline/dashboard -F @dotkomonline/rpc -F @dotkomonline/invoicification -F @dotkomonline/rif exec doppler run --preserve-env -- pnpm run dev", | ||
| "migrate": "pnpm -rc -F @dotkomonline/migrator exec doppler run -- pnpm run migrate", | ||
| "migrate-down": "pnpm -rc -F @dotkomonline/migrator exec doppler run -- pnpm run migrate -- down", | ||
| "migrate-down-all": "pnpm -rc -F @dotkomonline/migrator exec doppler run -- pnpm run migrate", | ||
| "migrate-with-fixtures": "pnpm -rc -F @dotkomonline/migrator exec doppler run -- pnpm run migrate latest --with-fixtures", | ||
| "migrate-with-sample-data": "pnpm -rc -F @dotkomonline/migrator exec doppler run -- pnpm run migrate -- latest --sample-data", |
| @@ -11,6 +11,7 @@ export interface UserRepository { | |||
| searchForUser(query: string, limit: number, page: number): Promise<User[]> | |||
| create(data: UserWrite, password: string): Promise<User> | |||
| registerId(auth0Id: string): Promise<void> | |||
| getByIdWithFeideAccessToken(id: UserId): Promise<{ user: User | null; accessToken: string | null }> | |||
There was a problem hiding this comment.
getWithFeideAccessTokenById?
Maybe a better name?
| courseGradeIndications[course.code] = { grade: course.year, credits: courseCredits } | ||
| } | ||
|
|
||
| console.log("Course year indications:", courseGradeIndications) |
junlarsen
requested changes
Feb 11, 2025
| export type Membership = z.infer<typeof MembershipSchema> | ||
| export type MembershipType = Membership["type"] | ||
|
|
||
| export function membershipValid(membership: Membership) { |
There was a problem hiding this comment.
Suggested change
| export function membershipValid(membership: Membership) { | |
| export function isMembershipValid(membership: Membership) { |
| return membershipGrade(membership) !== null || membership.type === "KNIGHT" | ||
| } | ||
|
|
||
| export function membershipGrade(membership: Membership): number | null { |
There was a problem hiding this comment.
Suggested change
| export function membershipGrade(membership: Membership): number | null { | |
| export function getMembershipGrade(membership: Membership): number | null { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: