Rewrite Grades v2 data synchronizer in async Rust #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junlarsen
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Also quite a bit of spaghetti here but it's good enough for an MVP imo |
junlarsen
requested review from
jotjern,
joleeee,
NjaalSoerland and
henrikskog
joleeee
requested changes
Feb 10, 2024
|
So the point of this is to update the grades.no backend db? |
We are replacing the entire site |
|
| let database_url = | ||
| std::env::var("DATABASE_URL").expect("missing DATABASE_URL environment variable"); | ||
| let max_connections = std::env::var("MAX_CONNECTIONS") | ||
| .unwrap_or_else(|_| "10".to_string()) |
There was a problem hiding this comment.
Maybe this could be a constant variable instead of a magic number?
|
Wild pull request, love it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still not too sure how good of an idea introducing Rust to the monorepo is but here goes
Ad-hoc Benchmarks
A lot of this speed is probably not rust, but...