Skip to content

Commit

Permalink
Build classic tests with build-tools 30.0.3 (#8602)
Browse files Browse the repository at this point in the history
Commit 60fd55e likely should have broken the release/7.0.4xx
build in the same way that it is currently failing:

    "/Users/builder/azdo/_work/4/s/xamarin-android/tests/Mono.Android-Tests/Runtime-MultiDex/Mono.Android-TestsMultiDex.csproj" (default target) (32:6) ->
    (_CompileToDalvik target) ->
      MSBUILD : java error JAVA0000: Error in /Users/builder/android-toolchain/sdk/build-tools/34.0.0/mainDexClasses.rules [/Users/builder/azdo/_work/4/s/xamarin-android/tests/Mono.Android-Tests/Runtime-MultiDex/Mono.Android-TestsMultiDex.csproj]
      MSBUILD : java error JAVA0000: Failed to read file: /Users/builder/android-toolchain/sdk/build-tools/34.0.0/mainDexClasses.rules [/Users/builder/azdo/_work/4/s/xamarin-android/tests/Mono.Android-Tests/Runtime-MultiDex/Mono.Android-TestsMultiDex.csproj]
      MSBUILD : java error JAVA0000: Compilation failed [/Users/builder/azdo/_work/4/s/xamarin-android/tests/Mono.Android-Tests/Runtime-MultiDex/Mono.Android-TestsMultiDex.csproj]

However, I believe builds including 60fd55e succeeded because the build
machines likely still had build-tools 32.0.0 packages installed.  Our
build pools are re-imaged and refreshed somewhat regularly, and they
seemingly no longer have build-tools 32.0.0 as we do not provision it.

The release/7.0.4xx branch does however still provision build-tools
30.0.3 for certain tests, and we can build our test projects
with this version to avoid the error highlighted above.
  • Loading branch information
pjcollins authored Dec 18, 2023
1 parent f311c5a commit 509379f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ endif

all-tests::
$(call MSBUILD_BINLOG,build-xabuild) /restore tools/xabuild/xabuild.csproj /p:Configuration=$(CONFIGURATION) $(_MSBUILD_ARGS)
MSBUILD="$(MSBUILD)" $(call MSBUILD_BINLOG,all-tests,tools/scripts/xabuild) /restore $(MSBUILD_FLAGS) Xamarin.Android-Tests.sln
MSBUILD="$(MSBUILD)" $(call MSBUILD_BINLOG,all-tests,tools/scripts/xabuild) /restore $(MSBUILD_FLAGS) Xamarin.Android-Tests.sln /p:AndroidSdkBuildToolsVersion=30.0.3

pack-dotnet::
$(call DOTNET_BINLOG,pack-dotnet) $(MSBUILD_FLAGS) -m:1 $(SOLUTION) -t:PackDotNet
Expand Down

0 comments on commit 509379f

Please sign in to comment.