Make PCS process all subscriptions, stop Maestro's triggerer #4249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkurepa
approved these changes
Dec 16, 2024
dkurepa
added a commit
to dkurepa/arcade-services
that referenced
this pull request
Dec 18, 2024
…otnet#4249)" This reverts commit 1f6977f.
dkurepa
added a commit
to dkurepa/arcade-services
that referenced
this pull request
Dec 18, 2024
…dotnet#4249)" This reverts commit 62d2887.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change deploys, both services will be able to trigger any subscription via the REST API and watch over the PRs until the PRs merge. However, Maestro won't run any scheduled triggers (weeekly, daily, ...) so it will technically only do two things:
PCS will start doing everything. It might open a duplicate PR if a scheduled trigger comes as it won't know about already opened PRs by Maestro.
#3808