Update package dependencies #6876
Conversation
| @@ -6,6 +6,8 @@ | |||
| <ImplicitUsings>enable</ImplicitUsings> | |||
| <Nullable>enable</Nullable> | |||
| <IsAspireHost>true</IsAspireHost> | |||
| <!-- This is an apphost project, doesn't need a Newtonsoft.Json reference --> | |||
| <AzureCosmosDisableNewtonsoftJsonCheck>true</AzureCosmosDisableNewtonsoftJsonCheck> | |||
There was a problem hiding this comment.
The new Azure Cosmos package added a target that runs on restore and surfaces an error when there is no direct dependency on Newtonsoft.Json. Full details can be found here: Azure/azure-cosmos-dotnet-v3#4839 but TL;DR is that they internally depend on newtonsoft but don't want to flow that transitive dependency and instead allow end-user applications to control the version they need.
In our repo, we disable this warning on all places where Newtonsoft isn't needed (as the Cosmos SDK won't run), and we reference Newtonsoft directly when necessary.
There was a problem hiding this comment.
Why is the AppHost project depending on the Cosmos SDK? Is it for the health check? If so, then I think we actually DO want Newtonsoft to be present, or else the AppHost is going to fail the health check when Newtonsoft tries to get loaded and it isn't in the bin directly.
|
|
||
| <!-- Azure Cosmos is now emitting a wanring if you are and end-user application and are not referencing Newtonsoft directly. | ||
| We disable that warning for this project as we are not a consumer application. --> | ||
| <AzureCosmosDisableNewtonsoftJsonCheck>true</AzureCosmosDisableNewtonsoftJsonCheck> |
There was a problem hiding this comment.
Let's just put this in the 2 projects that need it - not for every src project.
|
@joperezr I'm assuming this isn't required any more & doesn't need retargeting to main. The updates are outdated, and apparently we're doing fine without this warning disabled in main the last 2 months? |
Updating transitive dependencies from packages.
Microsoft Reviewers: Open in CodeFlow