Bump the priority of processing paramters to avoid infinite recursion #7588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to release/9.1 |
|
Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13305007421 |
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
JamesNK
approved these changes
Feb 13, 2025
| @@ -634,6 +634,13 @@ BicepValue<string> GetHostValue(string? prefix = null, string? suffix = null) | |||
| return (url, secretType); | |||
| } | |||
|
|
|||
| if (value is ParameterResource param) | |||
There was a problem hiding this comment.
Consider a comment saying that it's important that this is resolved before connection strings.
But if a test catches a regression then not required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Second part to #7500. Since we changed the connection string resource to be a parameter resource (that points to itself), we needed to bump the priority of processing parameters VS connection strings much like we did in manifest parsing.
Checklist