Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support connection_reset with HTTP/1.1 #58885

Open
1 task done
JamesNK opened this issue Nov 12, 2024 · 0 comments
Open
1 task done

Support connection_reset with HTTP/1.1 #58885

JamesNK opened this issue Nov 12, 2024 · 0 comments
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel

Comments

@JamesNK
Copy link
Member

JamesNK commented Nov 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Kestrel metrics supports connection_reset error status for connections:

The connection was reset while there were active HTTP/2 or HTTP/3 streams on the connection.

However, there should be support for HTTP/1.1 request unexpectedly ending and causing this error.

Expected Behavior

@halter73 at open-telemetry/semantic-conventions#1548 (comment):

It feels like there ought to be an equivalent to this for HTTP/1.1, although looking at the code I see that there isn't right now. I know we ignore any non-user-canceled write errors, and ignore ConnectionResetException for HTTP/1.1 reads if they're between requests, but what if we get an exception like that while reading HTTP/1.1 request headers? Or mid request body? I know we'll call Log.RequestProcessingError with the exception, but it looks like it might be treated as a graceful ConnectionEndReason.TransportCompleted for open telemetry purposes.

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

No response

Anything else?

No response

@JamesNK JamesNK added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel
Projects
None yet
Development

No branches or pull requests

1 participant