Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add known Kestrel connection error types #1548

Merged
merged 15 commits into from
Nov 15, 2024

Conversation

JamesNK
Copy link
Contributor

@JamesNK JamesNK commented Nov 5, 2024

Changes

.NET 9 adds connection error reasons to Kestrel connection duration metric. This PR updates the spec with the known types.

Preview: https://github.com/JamesNK/semantic-conventions/blob/jamesnk/kestrel-error-reason/docs/dotnet/dotnet-kestrel-metrics.md#metric-kestrelconnectionduration (scroll down to error.type table)

Merge requirement checklist

@JamesNK JamesNK requested review from a team as code owners November 5, 2024 05:49
docs/dotnet/dotnet-kestrel-metrics.md Outdated Show resolved Hide resolved
docs/dotnet/dotnet-kestrel-metrics.md Outdated Show resolved Hide resolved
docs/dotnet/dotnet-kestrel-metrics.md Outdated Show resolved Hide resolved
docs/dotnet/dotnet-kestrel-metrics.md Outdated Show resolved Hide resolved
docs/dotnet/dotnet-kestrel-metrics.md Outdated Show resolved Hide resolved
model/kestrel/metrics.yaml Outdated Show resolved Hide resolved
@JamesNK
Copy link
Contributor Author

JamesNK commented Nov 15, 2024

All done.

There is a warning that a link the markdown - https://blogs.oracle.com/linux/post/understanding-linux-kernel-memory-statistics - is dead when it's not.

Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@lmolkova lmolkova enabled auto-merge (squash) November 15, 2024 04:38
@lmolkova lmolkova merged commit e8135d3 into open-telemetry:main Nov 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants