Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Facebook Graph API version to v21.0 #59387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NSTom
Copy link

@NSTom NSTom commented Dec 9, 2024

Upgrade Facebook Graph API version to v21.0

Currently, ASP.NET Core uses version v14.0 of the Facebook Graph API for authentication. This version of the API is no longer supported by Facebook, and should be upgraded to v21.0.

Description

Version v14.0 of the Graph API was supported until September 17, 2024. We should be able to safely upgrade to v21.0, the latest version, since there are no documented changes to the authorization, token or user information endpoints between these versions.

While this contributes towards #4684, it does not completely fix it, since the scope of that issue is broader than just Facebook.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Dec 9, 2024
@NSTom
Copy link
Author

NSTom commented Dec 13, 2024

@microsoft-github-policy-service agree

@mkArtakMSFT
Copy link
Member

Thanks for the PR, @NSTom.
@halter73 do we have an easy way to validate the change. While @NSTom mentioned that there are no documented breaking changes, the major version change (multiple versions, actually) is somewhat risky.
Maybe, as a safety measure, we can take this into main and ship in early .NET 10 previews to get customer validation for the scenario.

@mkArtakMSFT mkArtakMSFT added area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer and removed area-security labels Dec 13, 2024
Copy link
Contributor

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Dec 21, 2024
@NSTom
Copy link
Author

NSTom commented Jan 21, 2025

@dotnet-policy-service agree company="Funda Real Estate B.V."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants