Powderhouse removed CliExit and fluent style for pipeline execution #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KathleenDollard
commented
May 27, 2024
KathleenDollard
commented
- Removed CLIExit (now using PipelineResult)
- PipelineResult is now returned from methods that create it and do other things.
- Renamed Handled to AlreadyHandled
The SetSuccess and NotRun methods are intended to abstract what those conditions mean from the actual properties that are set, probably making them private after discussio. I have more confidence in SetSuccess than NotRun
mhutch
approved these changes
May 31, 2024
Keboo
reviewed
Jun 2, 2024
| /// <returns>A CliExit object with information such as whether the CLI should terminate</returns> | ||
| protected internal virtual CliExit Execute(PipelineResult pipelineResult) | ||
| => CliExit.NotRun(pipelineResult.ParseResult); | ||
| /// <returns>A PipelineResult object with information such as whether the CLI should terminate</returns> |
There was a problem hiding this comment.
Suggested change
| /// <returns>A PipelineResult object with information such as whether the CLI should terminate</returns> |
Comment on lines
+18
to
+21
| public void NotRun(ParseResult? parseResult) | ||
| { | ||
| // no op because defaults are false and 0 | ||
| } |
There was a problem hiding this comment.
If this is going to be a no-op should we simply remove the method as not calling it does the same thing?
There was a problem hiding this comment.
Created an issue on this: #2443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.