Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Azure Service Bus integration doc #2365

Merged
merged 8 commits into from
Feb 11, 2025
Merged

Update Azure Service Bus integration doc #2365

merged 8 commits into from
Feb 11, 2025
+389 −87

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Jan 8, 2025 •
edited by github-actions bot
Loading

Summary

Caution

Currently blocked by the release of .NET Aspire 9.1. Various APIs and xref links will not render correctly and are missing.

Rewrite Azure Service Bus integration article.

Fixes #2308

Internal previews

📄 File 🔗 Preview link
docs/messaging/azure-service-bus-integration.md .NET Aspire Azure Service Bus integration

@dotnetrepoman dotnetrepoman bot added the messaging Content related to messaging. label Jan 8, 2025
@dotnet-policy-service dotnet-policy-service bot added the okr-quality Content-health KR: Concerns article defects/freshness or build warnings. label Jan 8, 2025
@IEvangelist IEvangelist requested a review from CamSoper January 8, 2025 20:08
@IEvangelist IEvangelist marked this pull request as draft January 8, 2025 20:08
@IEvangelist IEvangelist changed the title Fixes #2308 Update Azure Service Bus integration doc Jan 8, 2025
@CamSoper CamSoper requested a review from Copilot January 8, 2025 20:29
Copilot
Copilot AI reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

docs/snippets/azure/AppHost/Program.ConfigureServiceBusInfra.cs Show resolved Hide resolved
CamSoper
CamSoper approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@CamSoper CamSoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is there any way to do passwordless in Aspire? Should we include that information?

@IEvangelist IEvangelist mentioned this pull request Feb 5, 2025
Open
3 tasks
@IEvangelist IEvangelist changed the base branch from main to dotnet-aspire-9.1 February 6, 2025 21:06
@IEvangelist IEvangelist marked this pull request as ready for review February 6, 2025 21:09
@IEvangelist IEvangelist merged commit 119fd28 into dotnet:dotnet-aspire-9.1 Feb 11, 2025
5 of 6 checks passed
IEvangelist added a commit to IEvangelist/docs-aspire that referenced this pull request Feb 11, 2025
@IEvangelist
Update Azure Service Bus integration doc (dotnet#2365)
a95d4f1 
* Fixes dotnet#2308

* Fix tabs

* Fix a few more bits

* Remove subscription section and correct topics

* Fix port info

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@CamSoper CamSoper CamSoper approved these changes

Assignees
No one assigned
Labels
messaging Content related to messaging. okr-quality Content-health KR: Concerns article defects/freshness or build warnings.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite of the Azure Service Bus integration article
2 participants
@IEvangelist @CamSoper