Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Azure Key Vault content #2555
base: main
Are you sure you want to change the base?
Rewrite Azure Key Vault content #2555
Changes from 8 commits
17caeff
d351206
880fdc7
80fdb8f
90845b7
5032fb5
e2ac47c
a0fe879
eb6b1de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "toggle" and the "following Bicep" and "preceding Bicep" references to content only seen when the section is expanded seems likely to confuse many readers, as it did me. I read the reference to the "following Bicep" and the "preceding Bicep" and didn't see any, and it took a while for me comparing source in the PR to the review site before I realized this was an expanding/collapsing section. I think the reader experience would be better without the toggle. The blocks of code hidden by the toggle aren't so big as to be more of a nuisance when they're shown compared to needing to click on the toggle to see what blocks of code the text is referring to when they're hidden.