Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor corrections on resilience page #37869

Closed
wants to merge 0 commits into from
Closed

Minor corrections on resilience page #37869

wants to merge 0 commits into from

Conversation

peter-csala
Copy link
Contributor

@peter-csala peter-csala commented Nov 2, 2023 •
edited by github-actions bot
Loading

Summary

  • Removed the circuit breaker from the example
    • Added options to make the retry timeout-aware
    • Updated the key accordingly
  • Added AddConcurrencyLimiter next to AddRateLimiter
  • Corrected AddHedging description
    • The original description described the parallel mode, but it can work in latency and fallback modes as well.
  • Corrected the number of attempts in case of retry
  • Replaced await ValueTask.CompletedTask to return default

Internal previews

📄 File 🔗 Preview link
docs/core/resilience/index.md Introduction to resilient app development

@peter-csala peter-csala requested a review from a team as a code owner November 2, 2023 14:36
@dotnet-bot dotnet-bot added this to the November 2023 milestone Nov 2, 2023
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Nov 2, 2023
@peter-csala
Copy link
Contributor Author

peter-csala commented Nov 3, 2023 •
edited
Loading

@IEvangelist Hi David, can you please review it?

IEvangelist
IEvangelist approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good, except for the change to the execute call.

docs/core/resilience/snippets/resilience/Program.cs Outdated Show resolved Hide resolved
IEvangelist
IEvangelist approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we'll :shipit: - thank you 🙏

@IEvangelist IEvangelist enabled auto-merge (squash) November 7, 2023 00:30
@peter-csala
Copy link
Contributor Author

As far as I can the snippets-build step failed due to a package reference issue.

  • Referenced: 8.0.0-rtm.23517.3
  • Latest on nuget: 8.0.0-rc.2.23510.2

Shall I push a commit to change the csproj file?

@IEvangelist

@IEvangelist
Copy link
Member

As far as I can the snippets-build step failed due to a package reference issue.

  • Referenced: 8.0.0-rtm.23517.3
  • Latest on nuget: 8.0.0-rc.2.23510.2

Shall I push a commit to change the csproj file?

@IEvangelist

Yes, please - thank you.

auto-merge was automatically disabled November 7, 2023 19:31

Head branch was pushed to by a user without write access

@peter-csala
Copy link
Contributor Author

Shall I push a commit to change the csproj file?

Yes, please - thank you.

@IEvangelist Done :)

@IEvangelist IEvangelist enabled auto-merge (squash) November 7, 2023 20:27
@IEvangelist
Copy link
Member

Hey @peter-csala - I'll monitor this one and update it next week when .NET 8.0 ships, that way we can just use the stable release.

@peter-csala
Copy link
Contributor Author

Hey @peter-csala - I'll monitor this one and update it next week when .NET 8.0 ships, that way we can just use the stable release.

Thank you Sir ;)

auto-merge was automatically disabled November 15, 2023 09:15

Head branch was pushed to by a user without write access

@peter-csala peter-csala mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Milestone
November 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@peter-csala @IEvangelist @dotnet-bot