Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Semantic Kernel Pivot to Open AI Quick Starts #40205

Merged
merged 14 commits into from
Mar 26, 2024

Conversation

@dotnet-bot dotnet-bot added this to the March 2024 milestone Mar 25, 2024
@JakeRadMSFT JakeRadMSFT marked this pull request as ready for review March 26, 2024 00:04
@JakeRadMSFT JakeRadMSFT requested a review from a team as a code owner March 26, 2024 00:04
Copy link

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the order of setting up the secrets and using the Chat/Image services is backwards, as you set that up before getting the keys, so if you copy the code in as it stands it won't compile.

Given that there's repeated steps across each of them (setting up the secrets), should we pull that out as an include so we can have that referenced into each article rather than copy/pasted?

Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :shipit:

@JakeRadMSFT JakeRadMSFT merged commit 0b0737d into dotnet:main Mar 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants