Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new tutorial on upgrading #40212

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Add new tutorial on upgrading #40212

merged 6 commits into from
Mar 27, 2024

Conversation

richlander
Copy link
Member

@richlander richlander commented Mar 25, 2024

We are about to publish a blog post on .NET 7 EOL. Past posts like that have too much content and should primarily rely on content in docs.

Example:
https://devblogs.microsoft.com/dotnet/dotnet-5-end-of-support-update/

The tutorial is intended to be that content. I didn't find a doc like this. If there is, we can use that instead.

Is this a good home?


Internal previews

📄 File 🔗 Preview link
docs/core/install/upgrade.md Upgrade to a new .NET version

@dotnet-bot dotnet-bot added this to the March 2024 milestone Mar 25, 2024
@richlander richlander changed the title Add new tutoial on upgrading Add new tutorial on upgrading Mar 25, 2024
@richlander
Copy link
Member Author

I noticed a special mixture of "updating" and "upgrading". Well done!

docs/core/tutorials/upgrade.md Outdated Show resolved Hide resolved
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. I think it probably belongs in this section of the TOC/docs - Install .NET on Windows, Linux, and macOS | Microsoft Learn. It shouldn't be in the tutorials folder since it's not a tutorial. Specifically, it should probably live just above this article in the TOC:

image

docs/core/tutorials/upgrade.md Outdated Show resolved Hide resolved
docs/core/tutorials/upgrade.md Outdated Show resolved Hide resolved
docs/core/tutorials/upgrade.md Outdated Show resolved Hide resolved
docs/core/tutorials/upgrade.md Outdated Show resolved Hide resolved
docs/core/tutorials/upgrade.md Outdated Show resolved Hide resolved
docs/core/tutorials/upgrade.md Outdated Show resolved Hide resolved
docs/core/tutorials/upgrade.md Outdated Show resolved Hide resolved
docs/core/tutorials/upgrade.md Outdated Show resolved Hide resolved
docs/core/tutorials/upgrade.md Outdated Show resolved Hide resolved
docs/core/tutorials/upgrade.md Outdated Show resolved Hide resolved
@richlander
Copy link
Member Author

@gewarren -- I thought about putting this doc in that exact spot. However, I hesitated. It's not really about install as an intent, but upgrading to a new version. Perhaps that's splitting hairs. I'm happy to put it there if that's what folks think is best.

It's really "getting started with a new .NET version".

@tdykstra
Copy link
Contributor

@gewarren -- I thought about putting this doc in that exact spot. However, I hesitated. It's not really about install as an intent, but upgrading to a new version. Perhaps that's splitting hairs. I'm happy to put it there if that's what folks think is best.

It's really "getting started with a new .NET version".

I agree the location proposed by @gewarren isn't a perfect fit, but I think it's the best we have in this doc set. We have a whole TOC section devoted to upgrades in the ASP.NET Core docs.

@richlander richlander requested review from adegeo and a team as code owners March 26, 2024 23:46
@richlander
Copy link
Member Author

I believe I have resolved the feedback.

Mega thanks for the help and to @gewarren for all the edits.

docs/core/install/upgrade.md Outdated Show resolved Hide resolved
docs/core/install/upgrade.md Outdated Show resolved Hide resolved
docs/core/install/upgrade.md Outdated Show resolved Hide resolved
@gewarren gewarren enabled auto-merge (squash) March 27, 2024 03:28
@gewarren gewarren merged commit 7cc3687 into main Mar 27, 2024
8 checks passed
@gewarren gewarren deleted the upgrading-tutorial branch March 27, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants