-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BinaryFormatter Migration Guide #41564
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove the migration samples as we won't provide them (at least now) - remove WPF and WinForms part as it will be provided in Preview 7 - clarify the public type requirement for Messagepack - describe ArrayRecord and SZArrayRecord<T> - describe the OOB package
…but build produces warnings)
adamsitnik
requested review from
blowdart,
GrabYourPitchforks,
JeremyKuhne and
bartonjs
June 26, 2024 16:20
bartonjs
reviewed
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of time for today
docs/standard/serialization/binaryformatter-migration-guide/overview.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/overview.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/overview.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/overview.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/overview.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/reading-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/reading-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/reading-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/reading-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/reading-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeremy Barton <[email protected]>
gewarren
reviewed
Jul 17, 2024
docs/standard/serialization/binaryformatter-migration-guide/choosing-a-serializer.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/choosing-a-serializer.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/choosing-a-serializer.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/reading-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/reading-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/reading-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/reading-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/reading-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <[email protected]>
@gewarren big thanks for a very detailed review! |
gewarren
approved these changes
Jul 29, 2024
jeffhandley
changed the title
Binaryformatter migration guide
BinaryFormatter Migration Guide
Jul 31, 2024
jeffhandley
reviewed
Aug 7, 2024
docs/standard/serialization/binaryformatter-migration-guide/index.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/choose-a-serializer.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/read-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
…dotnet/docs into binaryformatter-migration-guide
Co-authored-by: Immo Landwerth <[email protected]>
…dotnet/docs into binaryformatter-migration-guide
jeffhandley
reviewed
Aug 7, 2024
docs/standard/serialization/binaryformatter-migration-guide/winforms-applications.md
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/wpf-applications.md
Show resolved
Hide resolved
jeffhandley
reviewed
Aug 7, 2024
docs/standard/serialization/binaryformatter-migration-guide/wpf-applications.md
Outdated
Show resolved
Hide resolved
adamsitnik
commented
Aug 7, 2024
.../standard/serialization/binaryformatter-migration-guide/migrate-to-datacontractserializer.md
Outdated
Show resolved
Hide resolved
lonitra
reviewed
Aug 7, 2024
docs/standard/serialization/binaryformatter-migration-guide/winforms-applications.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/winforms-applications.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/winforms-applications.md
Outdated
Show resolved
Hide resolved
jeffhandley
approved these changes
Aug 7, 2024
terrajobst
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will capture the initial publication of the BinaryFormatter Migration Guide, to be published before the release of .NET 9 Preview 7. The BinaryFormatter implementation was removed from the shared framework in .NET 9 Preview 6. The Migration Guide is intended to serve customers who are either surprised by this change or who have been aware the change was coming but now need to react to it.
The guide includes several sections and pages, with the following list tracking who is contributing each of the sections/pages. As pages are completed in this PR, we will check off the boxes in the list to indicate readiness for this PR to be merged.
Outstanding feedback/comments (as of Aug 6 @ 11:30pm PT):
index.md
functionality-reference.md
winforms-applications.md
winforms-wpf-ole-guidance.md
wpf-applications.md
choose-a-serializer.md
read-nrbf-payloads.md
To be addressed in a follow-up PR:
[Serializable]
attribute (to be assigned)Internal previews
Toggle expand/collapse