Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add line that positions NrbfDecoder as the equivalent of JSON/XML reader #42108

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Add line that positions NrbfDecoder as the equivalent of JSON/XML reader #42108

merged 2 commits into from
Aug 12, 2024

Conversation

terrajobst
Copy link
Member

@terrajobst terrajobst commented Aug 12, 2024 •
edited by github-actions bot
Loading

@terrajobst terrajobst requested review from gewarren and a team as code owners August 12, 2024 01:14
@dotnet-bot dotnet-bot added this to the August 2024 milestone Aug 12, 2024
@BillWagner BillWagner enabled auto-merge (squash) August 12, 2024 22:42
BillWagner
BillWagner approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @terrajobst I'll :shipit:

@BillWagner BillWagner merged commit d4c1306 into main Aug 12, 2024
8 checks passed
@BillWagner BillWagner deleted the nrbf-metaphor branch August 12, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@gewarren gewarren Awaiting requested review from gewarren gewarren is a code owner

@jeffhandley jeffhandley Awaiting requested review from jeffhandley

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
August 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@terrajobst @BillWagner @dotnet-bot