Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify using directive examples #43580

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Conversation

BillWagner
Copy link
Member

@BillWagner BillWagner commented Nov 14, 2024

Fixes dotnet#43136: Using directives can appear in namespace declarations, unless it's a global using.

Fixes dotnet#29746:  Add notes about how to get diagnostics on duplicated global usings, and considering a standard location for all global usings in a project.

Fixes dotnet#27331:  Rework a couple sentences for clarity.

Fixes dotnet#26469:  Add text an examples for the `::` token for qualified namespace aliases.
@dotnetrepoman dotnetrepoman bot added this to the November 2024 milestone Nov 14, 2024
@dotnet-policy-service dotnet-policy-service bot added okr-health okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. labels Nov 14, 2024
@BillWagner BillWagner closed this Nov 14, 2024
@BillWagner BillWagner reopened this Nov 14, 2024
@BillWagner BillWagner marked this pull request as ready for review November 15, 2024 20:24
@BillWagner BillWagner requested review from gewarren and a team as code owners November 15, 2024 20:24
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillWagner BillWagner merged commit b374b8b into dotnet:main Nov 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet-csharp/svc lang-reference/subsvc okr-health okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Projects
None yet
2 participants