Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detail about known error types to Kestrel connection metric #43584

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Nov 15, 2024

PR to add known error types has been merged on OTEL website: open-telemetry/semantic-conventions#1548

Update our doc to mention them and link to complete details.


Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/built-in-metrics-aspnetcore.md ASP.NET Core metrics

@JamesNK JamesNK requested review from tommcdon and a team as code owners November 15, 2024 06:55
@dotnetrepoman dotnetrepoman bot added this to the November 2024 milestone Nov 15, 2024
@JamesNK JamesNK requested review from noahfalk and samsp-msft and removed request for a team and tommcdon November 15, 2024 06:55
@JamesNK JamesNK changed the title Add detail about known error types to Kestrel connection instrument Add detail about known error types to Kestrel connection metric Nov 15, 2024
docs/core/diagnostics/built-in-metrics-aspnetcore.md Outdated Show resolved Hide resolved
docs/core/diagnostics/built-in-metrics-aspnetcore.md Outdated Show resolved Hide resolved
docs/core/diagnostics/built-in-metrics-aspnetcore.md Outdated Show resolved Hide resolved
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With @gewarren's changes applied I think it looks good!

Co-authored-by: Genevieve Warren <[email protected]>
@JamesNK JamesNK enabled auto-merge (squash) November 16, 2024 00:13
@JamesNK JamesNK merged commit 15ed17b into dotnet:main Nov 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants