Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Last System.Drawing Documentation for .NET 9 #10490

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lonitra
Copy link
Member

@lonitra lonitra commented Oct 2, 2024

Summary

Addresses remaining missing documentation for System.Drawing as outlined dotnet/winforms#11858 (comment)
Fixes dotnet/winforms#11858

@lonitra
Copy link
Member Author

lonitra commented Oct 2, 2024

cc: @carlossanlop

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions.

xml/System.Drawing.Imaging.Effects/Effect.xml Outdated Show resolved Hide resolved
xml/System.Drawing.Imaging.Effects/Effect.xml Outdated Show resolved Hide resolved
xml/System.Drawing.Imaging.Effects/Effect.xml Outdated Show resolved Hide resolved
xml/System.Drawing.Imaging.Effects/Effect.xml Outdated Show resolved Hide resolved
xml/System.Drawing/SystemColors.xml Outdated Show resolved Hide resolved
xml/System.Drawing/SystemColors.xml Outdated Show resolved Hide resolved
xml/System.Drawing/SystemColors.xml Outdated Show resolved Hide resolved
Co-authored-by: Carlos Sánchez López <[email protected]>

This comment was marked as outdated.

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more suggestion, otherwise LGTM.

Co-authored-by: Carlos Sánchez López <[email protected]>
Copy link

Learn Build status updates of commit 339c17b:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-System.Drawing.Imaging.Effects.xml ✅Succeeded View
xml/System.Drawing.Imaging.Effects/Effect.xml ✅Succeeded View
xml/System.Drawing/SystemColors.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 2, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-drawing

Copy link

Learn Build status updates of commit 97f1ff2:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-System.Drawing.Imaging.Effects.xml ✅Succeeded View
xml/System.Drawing.Imaging.Effects/Effect.xml ✅Succeeded View
xml/System.Drawing/SystemColors.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

xml/System.Drawing/SystemColors.xml Outdated Show resolved Hide resolved
xml/System.Drawing/SystemColors.xml Outdated Show resolved Hide resolved
Co-authored-by: Genevieve Warren <[email protected]>
Copy link

Learn Build status updates of commit 9a8d429:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-System.Drawing.Imaging.Effects.xml ✅Succeeded View
xml/System.Drawing.Imaging.Effects/Effect.xml ✅Succeeded View
xml/System.Drawing/SystemColors.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Drawing community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port System.Drawing docs for .NET 9 APIs
3 participants