Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

Add a NuGet sample #20

Merged
merged 1 commit into from
Aug 3, 2017
Merged

Add a NuGet sample #20

merged 1 commit into from
Aug 3, 2017

Conversation

guardrex
Copy link
Contributor

@dnfclas
Copy link

dnfclas commented Jul 13, 2017

@guardrex,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@guardrex
Copy link
Contributor Author

@sayedihashimi Could this one be merged (or updated+merged) quickly? ... I'd like to tie it directly into the tutorial topic.

@sayedihashimi sayedihashimi merged commit 491479a into dotnet:master Aug 3, 2017
@guardrex guardrex deleted the guardrex/add-nuget-pkg-sample branch August 3, 2017 19:59
@sayedihashimi
Copy link
Member

Sorry for the delay. I missed the pr. I just merged it.

mairaw pushed a commit to dotnet/docs that referenced this pull request Aug 12, 2017
…new (#2495)

* Add custom templates content

Update

* Add preview warning includes file

* Updates

* Updates

* Updates

* React to feedback

* React to feedback

* Add template links to See also section

* Remove -all|--show-all option

Per dotnet/templating#1033

* React to feedback

* Updates and add explicit creation steps

* Establish tutorial content

* Updates

* Updates

* Updates

* Updates

* Updates

* Updates

* Surface the sample template (dotnet-template-samples repo)

It just merged:
dotnet/dotnet-template-samples#20

* some updates

* readding 1.x, adding tabs

* updated name

* Update dotnet-new.md

* Update create-custom-template.md
@neman
Copy link

neman commented Sep 18, 2017

There are 15 projects following certain name convention and this PR crushed that all!
For example Project names are in the form of MyProject.Con and here we have GarciaSoftware.ConsoleTemplate.CSharp !
Also template.json are following some convention until this PR

"name": "Contoso Sample #",
  "identity": "MyProject.#.Sample.CSharp",         
  "groupIdentity":"MyProject.#.Sample",
  "shortName": "sample#",

And here we got

{
  "$schema": "http://json.schemastore.org/template",
  "author": "Catalina Garcia",
  "classifications": [ "Common", "Console" ],
  "identity": "GarciaSoftware.ConsoleTemplate.CSharp",
  "name": "Garcia Software Console Application",
  "shortName": "garciaconsole"
}

Should contributors follow some rules and naming convention, or is it fine that we write whatever we like?

@guardrex
Copy link
Contributor Author

@neman It happened inadvertently. This is a sample attached to the Custom Templates topic that was dropped in over here after that topic and the sample were created. That's why it doesn't match.

@sayedihashimi @mairaw may order some changes to both based on your issue.

@sayedihashimi
Copy link
Member

Created #29 to track getting these updated.

mairaw pushed a commit to mairaw/dotnet-api-docs-old that referenced this pull request Mar 29, 2018
…new (#2495)

* Add custom templates content

Update

* Add preview warning includes file

* Updates

* Updates

* Updates

* React to feedback

* React to feedback

* Add template links to See also section

* Remove -all|--show-all option

Per dotnet/templating#1033

* React to feedback

* Updates and add explicit creation steps

* Establish tutorial content

* Updates

* Updates

* Updates

* Updates

* Updates

* Updates

* Surface the sample template (dotnet-template-samples repo)

It just merged:
dotnet/dotnet-template-samples#20

* some updates

* readding 1.x, adding tabs

* updated name

* Update dotnet-new.md

* Update create-custom-template.md
mairaw pushed a commit to mairaw/dotnet-api-docs-old that referenced this pull request Mar 29, 2018
…new (#2495)

* Add custom templates content

Update

* Add preview warning includes file

* Updates

* Updates

* Updates

* React to feedback

* React to feedback

* Add template links to See also section

* Remove -all|--show-all option

Per dotnet/templating#1033

* React to feedback

* Updates and add explicit creation steps

* Establish tutorial content

* Updates

* Updates

* Updates

* Updates

* Updates

* Updates

* Surface the sample template (dotnet-template-samples repo)

It just merged:
dotnet/dotnet-template-samples#20

* some updates

* readding 1.x, adding tabs

* updated name

* Update dotnet-new.md

* Update create-custom-template.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants