In VisitUpdate, match table by alias rather than the exact same instance #34601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to same table, even if not the same instance
|
@dotnet-policy-service agree |
|
@roji Are we waiting on anything before this can me merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VisitUpdatewas usingReferenceEqualsto match tables, which would only match if it was the same instance. It actually should be matching if the tables are the same even if the instance is different.The only affected test is
Replace_ColumnExpression_in_column_setter.The sqlite test now works and the same change solves the problem for efcore.pg. SQL Server is unaffected as it has its own override which doesn't do this check
Fixes #33947