[release/9.0] Use the correct comparer when sorting relational functions. #34712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
approved these changes
Sep 19, 2024
|
@artl93 - this was reported off RC1, a regression fix. |
|
It looks like we're modifying an existing test to cover the new case rather than adding a new test. This makes it difficult to see if we're ensuring compatibility with prior, assumed behaviors. Is the way we're doing this intentional? |
We have other tests that only add one function per entity type. I prefer to avoid duplicate coverage to avoid additional maintenance costs and keep our test suite running fast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34672
Description
The implementation of
IRelationalModel.Functionsdidn't specify a comparer and the default fails when trying to compare two instances. This regressed in d8e9f61Customer impact
When a model contains more than one function that returns the same entity type an exception is thrown in validation. There is no known workaround.
How found
Reported by user on 9.0.0-rc1.
Regression
Yes. From 8.0.x
Testing
Test added.
Risk
Low.